Create sk-SK.h - #2091
Merged
Merged
Create sk-SK.h#2091
Conversation
tonhuisman
suggested changes
Apr 28, 2024
Comment on lines
+4
to
+5
| #ifndef LOCALE_SK-SK_H_ | ||
| #define LOCALE_SK-SK_H_ |
Contributor
There was a problem hiding this comment.
As the build failure says, that dash - should be an underscore _...
Owner
There was a problem hiding this comment.
Yep.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
| "Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \ | ||
| "Upraviť a zväčšiť `kCaptureBufferSize`." | ||
|
|
||
| #endif // LOCALE_SK-SK_H_ |
Contributor
There was a problem hiding this comment.
Same error as at the top...
Owner
There was a problem hiding this comment.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
crankyoldgit
requested changes
Apr 28, 2024
crankyoldgit
left a comment
Owner
There was a problem hiding this comment.
Awesome. Thanks for adding this. Great effort! Just a few fixes and some stuff you should be able to remove.
| "Tomuto výsledku by sa nemalo dôverovať, kým sa to nevyrieši. " \ | ||
| "Upraviť a zväčšiť `kCaptureBufferSize`." | ||
|
|
||
| #endif // LOCALE_SK-SK_H_ |
Owner
There was a problem hiding this comment.
src/locale/sk-SK.h:4: #ifndef header guard has wrong style, please use: LOCALE_SK_SK_H_ [build/header_guard] [5]
src/locale/sk-SK.h:3[9](https://github.com/crankyoldgit/IRremoteESP8266/actions/runs/8870139943/job/24351598938?pr=2091#step:6:10)3: #endif line should be "#endif // LOCALE_SK_SK_H_" [build/header_guard] [5]
Comment on lines
+17
to
+18
| #define D_STR_TURBO "Turbo" | ||
| #define D_STR_SUPER "Super" |
Owner
There was a problem hiding this comment.
When they are the same as the default, please don't include them.
i.e. You should be able to remove these two lines.
| #define D_STR_LIGHT "Svetlo" | ||
| #define D_STR_POWERFUL "Výkonný" | ||
| #define D_STR_QUIET "Tichý" | ||
| #define D_STR_ECONO "Econo" |
| #define D_STR_FILTER "Filter" | ||
| #define D_STR_3D "3D" | ||
| #define D_STR_CELSIUS "Celzia" | ||
| #define D_STR_FAHRENHEIT "Fahrenheit" |
Comment on lines
+65
to
+66
| #define D_STR_START "Štart" | ||
| #define D_STR_STOP "Stop" |
Owner
There was a problem hiding this comment.
Oops. Yeah, just remove Stop
| #define D_STR_DISPLAY "Displej" | ||
| #define D_STR_WEEKLY "Týždenne" | ||
| #define D_STR_WEEKLYTIMER D_STR_WEEKLY " " D_STR_TIMER // Needs `D_STR_WEEKLY`! | ||
| #define D_STR_WIFI "WiFi" |
Comment on lines
+123
to
+126
| #define D_STR_MAX "Max" | ||
| #define D_STR_MAXIMUM "Maximum" | ||
| #define D_STR_MIN "Min" | ||
| #define D_STR_MINIMUM "Minimum" |
Comment on lines
+197
to
+198
| #define D_STR_TRUE "True" | ||
| #define D_STR_FALSE "False" |
Comment on lines
+202
to
+226
|
|
||
| // Model Names | ||
| #define D_STR_YAW1F "YAW1F" | ||
| #define D_STR_YBOFB "YBOFB" | ||
| #define D_STR_YX1FSF "YX1FSF" | ||
| #define D_STR_V9014557_A "V9014557-A" | ||
| #define D_STR_V9014557_B "V9014557-B" | ||
| #define D_STR_RLT0541HTA_A "R-LT0541-HTA-A" | ||
| #define D_STR_RLT0541HTA_B "R-LT0541-HTA-B" | ||
| #define D_STR_ARRAH2E "ARRAH2E" | ||
| #define D_STR_ARDB1 "ARDB1" | ||
| #define D_STR_ARREB1E "ARREB1E" | ||
| #define D_STR_ARJW2 "ARJW2" | ||
| #define D_STR_ARRY4 "ARRY4" | ||
| #define D_STR_ARREW4E "ARREW4E" | ||
| #define D_STR_GE6711AR2853M "GE6711AR2853M" | ||
| #define D_STR_AKB75215403 "AKB75215403" | ||
| #define D_STR_AKB74955603 "AKB74955603" | ||
| #define D_STR_AKB73757604 "AKB73757604" | ||
| #define D_STR_LG6711A20083V "LG6711A20083V" | ||
| #define D_STR_KKG9AC1 "KKG9AC1" | ||
| #define D_STR_KKG29AC1 "KKG29AC1" | ||
| #define D_STR_LKE "LKE" | ||
| #define D_STR_NKE "NKE" | ||
| #define D_STR_DKE "DKE" |
Owner
There was a problem hiding this comment.
You should be able to remove all the model & protocol names.
Review feedback corrections.
crankyoldgit
self-requested a review
May 12, 2024 11:03
crankyoldgit
approved these changes
May 12, 2024
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2026
**[Bug Fixes]** - Bosch: Fixed the bug where the wind speed was always set to auto. (#2237) - Update IRsend sendHaierAC to include SEND_HAIER_AC160 (#2172) - Gree: Fix reporting vertical swing (#2125) - Fix `decodeYork()` parameter names & defaults. (#2121) - Fix the Coolix fan-only mode in IRac class. (#2104) - Fix missing quiet parameter of haier176 (#2102) - ESP32-C3: Fix compilation error when USB CDC on Boot is enabled (#2080) **[Features]** - Add Fahrenheit support for the BOSCH144 protocol (#2224) - Build: Add compatibility with C++20 (#2040) - Add initial detailed support for Kelon168 (Kelon/Hisense) (#1949) - Add support for the Eurom A/C protocol (#2208) - Add Fahrenheit support for Coolix (#2214) - ESP32: Esp32 Core version 3 support (#2144) - auto_analyse_raw_data: Add kXxMsbFirst to easy change MSBFirst for the full protocol (#2143) - change kAirtonMaxTemp from 25C to 31C (#2124) - Added support for Bluestar Heavy AC (#2120) - Add support of Toshiba Remote Control B (#2094) - Update haier160 & HaierYRWO2 to use quiet in the common class. (#2115) - Internationalisation: Solvakian translation (#2091) - Daikin: Support setting temperature in 0.5 C unit (#2036) - Quiet/Silent Mode for Electra_AC (#1990) **[Misc]** - Document Fischer R51L1/BGE remote support (#2231) - CI: pin python v3.13 - CI: Attempt to fix intelhex failures - IRMQTTServer: Fixes for ArduinoJson v7 to remove depreicated calls - docs: updated contributing section for clarity (by Prerna Utage) (#2221) - Fix typo in Russian language support (#2210) - Build: Update CodeQL actions plugin to use v3 as v2 will be deprecated soon - Build: Fix soon to be deprecated set-output command - Build: Update build scripts to use non-deprecated actions tooling - Fix linter issues (#2173) - pylint fix raw_to_pronto_code.py (#2150) - Document support for Comfee model (#2147) - DAIKIN: ARC443A5 Remote supported note (#2138) - library.json specifies libCompatMode strict (#2111) - Added Electrolux EACM CL/N3 series remote to TCL protocol (#2100) - Add AR-JW19 to supported devices (#2069) - Remove unused constant `kRcmmExcess` (#2033) - Panasonic AC: Document support for PV1122V remote (#2029) - Document support for Panasonic CS-E12QKEW A/C (#2028)
Closed
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2026
**[Bug Fixes]** - Bosch: Fixed the bug where the wind speed was always set to auto. (#2237) - Update IRsend sendHaierAC to include SEND_HAIER_AC160 (#2172) - Gree: Fix reporting vertical swing (#2125) - Fix `decodeYork()` parameter names & defaults. (#2121) - Fix the Coolix fan-only mode in IRac class. (#2104) - Fix missing quiet parameter of haier176 (#2102) - ESP32-C3: Fix compilation error when USB CDC on Boot is enabled (#2080) **[Features]** - Add Fahrenheit support for the BOSCH144 protocol (#2224) - Build: Add compatibility with C++20 (#2040) - Add initial detailed support for Kelon168 (Kelon/Hisense) (#1949) - Add support for the Eurom A/C protocol (#2208) - Add Fahrenheit support for Coolix (#2214) - ESP32: Esp32 Core version 3 support (#2144) - auto_analyse_raw_data: Add kXxMsbFirst to easy change MSBFirst for the full protocol (#2143) - change kAirtonMaxTemp from 25C to 31C (#2124) - Added support for Bluestar Heavy AC (#2120) - Add support of Toshiba Remote Control B (#2094) - Update haier160 & HaierYRWO2 to use quiet in the common class. (#2115) - Internationalisation: Solvakian translation (#2091) - Daikin: Support setting temperature in 0.5 C unit (#2036) - Quiet/Silent Mode for Electra_AC (#1990) **[Misc]** - Document Fischer R51L1/BGE remote support (#2231) - CI: pin python v3.13 - CI: Attempt to fix intelhex failures - IRMQTTServer: Fixes for ArduinoJson v7 to remove depreicated calls - docs: updated contributing section for clarity (by Prerna Utage) (#2221) - Fix typo in Russian language support (#2210) - Build: Update CodeQL actions plugin to use v3 as v2 will be deprecated soon - Build: Fix soon to be deprecated set-output command - Build: Update build scripts to use non-deprecated actions tooling - Fix linter issues (#2173) - pylint fix raw_to_pronto_code.py (#2150) - Document support for Comfee model (#2147) - DAIKIN: ARC443A5 Remote supported note (#2138) - library.json specifies libCompatMode strict (#2111) - Added Electrolux EACM CL/N3 series remote to TCL protocol (#2100) - Add AR-JW19 to supported devices (#2069) - Remove unused constant `kRcmmExcess` (#2033) - Panasonic AC: Document support for PV1122V remote (#2029) - Document support for Panasonic CS-E12QKEW A/C (#2028)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jan 2, 2026
_v2.9.0 (20260103)_ release **[Bug Fixes]** - Bosch: Fixed the bug where the wind speed was always set to auto. (#2237) - Update IRsend sendHaierAC to include SEND_HAIER_AC160 (#2172) - Gree: Fix reporting vertical swing (#2125) - Fix `decodeYork()` parameter names & defaults. (#2121) - Fix the Coolix fan-only mode in IRac class. (#2104) - Fix missing quiet parameter of haier176 (#2102) - ESP32-C3: Fix compilation error when USB CDC on Boot is enabled (#2080) **[Features]** - Add Fahrenheit support for the BOSCH144 protocol (#2224) - Build: Add compatibility with C++20 (#2040) - Add initial detailed support for Kelon168 (Kelon/Hisense) (#1949) - Add support for the Eurom A/C protocol (#2208) - Add Fahrenheit support for Coolix (#2214) - ESP32: Esp32 Core version 3 support (#2144) - auto_analyse_raw_data: Add kXxMsbFirst to easy change MSBFirst for the full protocol (#2143) - change kAirtonMaxTemp from 25C to 31C (#2124) - Added support for Bluestar Heavy AC (#2120) - Add support of Toshiba Remote Control B (#2094) - Update haier160 & HaierYRWO2 to use quiet in the common class. (#2115) - Internationalisation: Solvakian translation (#2091) - Daikin: Support setting temperature in 0.5 C unit (#2036) - Quiet/Silent Mode for Electra_AC (#1990) **[Misc]** - Document Fischer R51L1/BGE remote support (#2231) - CI: pin python v3.13 - CI: Attempt to fix intelhex failures - IRMQTTServer: Fixes for ArduinoJson v7 to remove depreicated calls - docs: updated contributing section for clarity (by Prerna Utage) (#2221) - Fix typo in Russian language support (#2210) - Build: Update CodeQL actions plugin to use v3 as v2 will be deprecated soon - Build: Fix soon to be deprecated set-output command - Build: Update build scripts to use non-deprecated actions tooling - Fix linter issues (#2173) - pylint fix raw_to_pronto_code.py (#2150) - Document support for Comfee model (#2147) - DAIKIN: ARC443A5 Remote supported note (#2138) - library.json specifies libCompatMode strict (#2111) - Added Electrolux EACM CL/N3 series remote to TCL protocol (#2100) - Add AR-JW19 to supported devices (#2069) - Remove unused constant `kRcmmExcess` (#2033) - Panasonic AC: Document support for PV1122V remote (#2029) - Document support for Panasonic CS-E12QKEW A/C (#2028)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slovak language