Sitelet https://github.com/crankyoldgit/IRremoteESP8266/pull/1106
Skip to content

Add support for Multibrackets protocol. - #1106

Merged
crankyoldgit merged 3 commits into
masterfrom
multibrackets
May 12, 2020
Merged

Add support for Multibrackets protocol.#1106
crankyoldgit merged 3 commits into
masterfrom
multibrackets

Conversation

@crankyoldgit

@crankyoldgit crankyoldgit commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Owner
  • Basic send/decode support only. It's a very simple protocol.
  • Unit tests etc.

Fixes #1103

@crankyoldgit crankyoldgit self-assigned this May 7, 2020
@crankyoldgit

crankyoldgit commented May 12, 2020

Copy link
Copy Markdown
Owner Author

@NiKiZe re: 5fa5c6e

I tend to git rebase and fix up the merge issues in either another commit or during the rebase, and do a push --force to sync up.
My (personal) principle is keep the change/PR as clean as possible w.r.t. to the master branch.
i.e. Only import(merge) the bare minimum from master to get it to still merge cleanly.

@NiKiZe

NiKiZe commented May 12, 2020

Copy link
Copy Markdown
Collaborator

@NiKiZe re: 5fa5c6e

My (personal) principle is keep the change/PR as clean as possible w.r.t. to the master branch.
i.e. Only import(merge) the bare minimum from master to get it to still merge cleanly.

yes GitHub sucks :D, I would prefer a clean rebase, goal was to minimize the total changes in the PR to simplify review.
And it was a cleanup commit to fix the conflicts i attempted, not (a hated) merge shrugs

NiKiZe
NiKiZe approved these changes May 12, 2020
View reviewed changes

@NiKiZe NiKiZe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Simple" protocol add

There is no generic handlers for this type of encoding(?)

LGTM

Comment thread src/IRremoteESP8266.h Outdated
@crankyoldgit

crankyoldgit commented May 12, 2020

Copy link
Copy Markdown
Owner Author

There is no generic handlers for this type of encoding(?)

Not really/yet. This is only the second protocol (IIRC) that I've added that has a n-bit per pulse (mark or space). The other (RCMM I think) had a slightly different approach. A generic encoder/decoder tends to pay for it's self (code-space-wise) after about two+ protocols with the same mechanism.

@crankyoldgit
Add support for Multibrackets protocol.
4bda60a 
* Basic send/decode support only. It's a very simple protocol.
* Unit tests etc.

Ref #1103
@crankyoldgit
Add more decoding tests.
25d69bc 
* More confident decoding works. Increase to Beta.
@crankyoldgit
Simplify code, more comments, and update supported doc.
116ea9d
@crankyoldgit
crankyoldgit merged commit 2799b84 into master May 12, 2020
@crankyoldgit
crankyoldgit deleted the multibrackets branch May 12, 2020 14:12
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
01a555b 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, @1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)
@crankyoldgit crankyoldgit mentioned this pull request May 19, 2020
Merged
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
e2a8674 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, @1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
crankyoldgit added a commit that referenced this pull request May 19, 2020
@crankyoldgit
v2.7.7 release
e69a119 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, #1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
crankyoldgit added a commit that referenced this pull request May 20, 2020
@crankyoldgit
v2.7.7 release (#1132)
691a05d 
_v2.7.7 (20200519)_

**[BREAKING CHANGES]**
- Fix Symphony protocol. (#1107, #1105)
  * Now 12 bits and bits are inverted. All previous codes will no longer work.
- IRMQTTServer: Better handle power & mode operations for Home Assistant. (#1099, #1092)
  * When `MQTT_CLIMATE_HA_MODE` is enabled (default) this will break previous operation mode resumption when power is changed.

**[Bug Fixes]**
- Set correct return type for `.calibrate()` (#1095, #1093)

**[Features]**
- Add basic support for Carrier 40 & 64 bit protocols. (#1125, #1112, #1127)
- Gree: Enable native support for Fahrenheit (#1124, #1121)
- Gree: Add option to control display temp source. (#1120, #1118)
- Add support for Multibrackets protocol. (#1106, #1103)
- Add RawToPronto.py tool & improve `sendPronto()` precision (#1104, #1103)
- Add support for `Doshisha` LED light protocol (#1115)
- Introduce IRrecvDumpV3 with basic OTA update support (#1111)
- Add detailed support for Delonghi A/C (#1098, #1096)
- Improved support for SharpAc. (#1094, #1091)
- Update auto_analyse to use new decode call structure. (#1102, #1097)
- Added Blynk app example (#1090)

**[Misc]**
- update auto_analyse script to use new param documentation (#1126)
- Improve `raw_to_pronto_code.py` (#1122, #1103)
- Use pattern rules in Makefiles to reduce specific rule (#1110)
- Update list of supported Daikin models. (#1101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes
@bwarden bwarden Awaiting requested review from bwarden
@jamsinclair jamsinclair Awaiting requested review from jamsinclair

Assignees

@crankyoldgit crankyoldgit

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to interpret raw codes as binary, for Multibrackets motorized device

2 participants

@crankyoldgit @NiKiZe