Fix 14956: FP arrayIndexOutOfBounds with break in loop - #8772
Conversation
| " arr[idx] = 0;\n" | ||
| "}\n"); | ||
| ASSERT_EQUALS( | ||
| "[test.cpp:9:8]: (error) Array 'arr[3]' accessed at index 3, which is out of bounds. [arrayIndexOutOfBounds]\n", |
There was a problem hiding this comment.
Hi! I am new so sorry if this is a silly question.
I thought that if we want to return an error, we must be guaranteed that it is actually an error. In this input it looks like the array access is only out of bounds if c is true. Since we don't know anything about c, I thought we couldn't report any errors. I would expect the correct output for this testcase to be no errors.
There was a problem hiding this comment.
hi @aadanen thanks for your question. Sorry for slow reply.
I feel this testcase is OK. If c is always false then the error would technically be a false positive. However then the condition would be redundant and the user should remove it.
Theoretically it would be an improvement to say something like "Either the condition (c) is redundant or there can be array index out of bounds".
|
I wonder if we could catch cases like this as well: which currently produces |
that is a false positive! @pfultz2 I assume a ticket should be created? I can create it unless you feel you will fix it in this PR.. |
No description provided.