ENT-6871: Clean up & apply formatting to Java tutorial-applestamp - #82
Merged
Merged
Conversation
Removed unused imports and applied formatting.
r3hj
commented
Jul 14, 2022
| public interface Commands extends CommandData { | ||
| //In our hello-world app, We will have two commands. | ||
| class Issue implements AppleStampContract.Commands {} | ||
| class Issue implements AppleStampContract.Commands { |
Contributor
Author
There was a problem hiding this comment.
Though it's done by Intellij auto-formatting, {} looks good to me too. Please let me know if this shouldn't be changed. I'll revert it.
r3hj
commented
Jul 14, 2022
| public interface Commands extends CommandData { | ||
| //In our hello-world app, We will only have one command. | ||
| class Send implements Commands {} | ||
| class Send implements Commands { |
Contributor
Author
There was a problem hiding this comment.
Same here. If preferred the original format, I'll revert it.
r3hj
commented
Jul 14, 2022
| import net.corda.core.transactions.LedgerTransaction; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| import static net.corda.core.contracts.ContractsDSL.requireThat; //Domain Specific Language |
Contributor
Author
There was a problem hiding this comment.
If the comment is intended and might be useful, I'll add it back.
peterli-r3
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview / Changes
Removed unused imports and applied formatting to
tutorial-applestampJava sample project.This clean-up is done as part of improving Corda 4.9 tutorial document and its scope is limited to
tutorial-applestamp.Note: Intellij auto-formatting feature (both for imports and logic) is used. Though it doesn't always provide the best formatting, in most cases it gives a better and consistent formatting.
Test
No logic change. Ran
./gradlew buildand verified it succeeded.