feat: add support for Ambassador API gateway in provider detection an… - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes and one new provider.
Fix: YAML modal close button unresponsive (IngressDetail, NodeDetail)
IngressDetailandNodeDetailhadoverflow-y-autoon their root div. When the events tab (IngressDetail) or a long pod/conditions list (NodeDetail) caused the container to scroll, Chromium's hit-test coordinates for anyposition: fixedchild were offset by the scroll amount — so clicking the visually-correct close button registered a miss. Fixed by changing the root tooverflow-hiddenand placing only scrollable body content inside aflex-1 overflow-y-autoinner wrapper, keeping the fixed modal outside any scroll container. Also addedoverflow-y-autoto the IngressDetail events tab, which was the only tab missing it (causing the root to actually scroll).Fix: IngressDetail events tab Refresh button scrolls away
After the overflow fix, the events tab toolbar (header + Refresh button) was inside the scroll region, so it disappeared when the event list was long. Separated the toolbar into a
shrink-0row above a dedicatedflex-1 overflow-y-autoevent list, matching the pattern other tabs already used.Feat: Ambassador API gateway provider
Detects Ambassador / Emissary-Ingress via the
getambassador.ioAPI group and surfaces four core resource sections in the sidebar: Mappings, Hosts, TLS Contexts, TCP Mappings. Follows the identical pattern used for Istio, Traefik, NGINX Inc, and KEDA — no new abstractions.Type of change
Checklist
npm run buildpasses cleanlynpm run testpassescd go-core && go test ./...passes