Fix instrumentation causing spurious reflection warnings - #366

sh -c '
cat > deps.edn <<\EOF
{:paths ["."]
 :deps {org.clojure/clojure {:mvn/version "1.12.6"}}
 :aliases
 {:run
  {:main-opts ["-m" "cloverage.coverage" "--ns-regex" "a|b" "--test-ns-regex" "a-test" "--no-html" "--no-summary"]}
  :before
  {:extra-deps
   {cloverage/cloverage
    {:git/url "https://github.com/cloverage/cloverage"
     :git/sha "61e3cac426e9907a9dd01c37597f85c71a57ff90"
     :deps/root "cloverage"}}}
  :after
  {:extra-deps
   {cloverage/cloverage
    {:git/url "https://github.com/imrekoszo/cloverage"
     :git/sha "1160ed138a8eca4cc4673bfafa3ddf6af864305f"
     :deps/root "cloverage"}}}}}
EOF

cat > a.clj <<\EOF
(ns a
  (:import (java.util.concurrent.atomic AtomicReference)))

(set! *warn-on-reflection* true)

(defn class-tag
  "the pr-str var has a Class :tag"
  [x]
  (.length (pr-str x)))

(defn- hinted ^String [x] (str x))

(defn arglist-tag
  "return hint on the arglist"
  [x]
  (.length (hinted x)))

(defn static-call
  "Clojure 1.12 Class/method"
  [^String s]
  (.booleanValue (Boolean/valueOf s)))

(defn dot-form-meta
  "hint on a . form"
  [^AtomicReference r]
  (.length ^String (.get r)))
EOF

cat > b.clj <<\EOF
(ns b
  "No (set! *warn-on-reflection* true) here, so its reflection is not reported by a plain load."
  (:require [a]))

(defn leak [x]
  (.length x))
EOF

cat > a_test.clj <<\EOF
(ns a-test
  (:require [clojure.test :refer [deftest is]]
            [a]
            [b]))

(deftest smoke
  (is (= 1 (a/class-tag 1)))
  (is (= 1 (a/arglist-tag 1)))
  (is (true? (a/static-call "true")))
  (is (= 1 (a/dot-form-meta (java.util.concurrent.atomic.AtomicReference. "x"))))
  (is (= 1 (b/leak "x"))))
EOF

cat > run.sh <<\EOF
#!/usr/bin/env sh
# Counts reflection warnings for a plain load vs. cloverage before/after the fix.
cd "$(dirname "$0")" || exit

warnings() { grep -E "Reflection warning|Error|Exception|assertions|failures" | sed "s/^Reflection warning, //" ; }

echo "== plain load of b.clj (expected: none) =="
clojure -M -e "(require (quote b))" 2>&1 | warnings

cloverage() {
  echo "== cloverage $1 ($2) =="
  clojure "-M:$1:run" 2>&1 | warnings
}

cloverage before "expected: 5 in a.clj (due to instrumentation), 1 in b.clj (due to *warn-on-reflection* leaking from a.clj to b.clj)"
cloverage after "expected: none"
EOF

chmod +x run.sh && ./run.sh
'