fix: require callable iterators in iterable assertions - #1861
Merged
Merged
Conversation
43081j
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expect({ [Symbol.iterator]: true }).to.be.iterableandassert.isIterable(...)currently pass, even though the value cannot be iterated. Passing it to.members()then throws a nativeTypeErrorfromArray.frominstead of anAssertionError.Require
Symbol.iteratorto be a function in both iterable checks. This also makes.not.iterableaccept these non-iterable objects and lets.members()reject either invalid input through its existing assertion guard.Regression coverage includes truthy non-function iterator properties, negation, both member-comparison inputs, custom messages, a generator iterator, and checking iterability without calling the method. The six affected test cases fail against unchanged
mainand pass with the fix.Validation:
pnpm run buildpnpm test: lint and formatting, 512 Node tests, 511 Chromium testspnpm run test-chrome --browsers firefox: Firefox could not start on this macOS 27.0 host. A standalone Playwright Firefox launch also times out before loading any test code.pnpm run lint:typesstill fails with the same 601 existing diagnostics as unchangedmain, after normalizing source positions.AI assistance: Tested using Codex.