fix(a11y): avoid empty label in ToggleSmall - #1771
Conversation
Fixes #1183.
|
Deploy preview for carbon-components-react ready! Built with commit 45138a5 https://deploy-preview-1771--carbon-components-react.netlify.com |
emyarod
left a comment
There was a problem hiding this comment.
the original reporter stated that the label needs to be before the input, is that still the case?
|
was going to say the same thing. not sure if valuable to merge in this fix in now as one PR, then refactor the label>input order later? |
|
Good catch @emyarod! Some research suggested that the order is for screen magnifier: https://www.w3.org/TR/UNDERSTANDING-WCAG20/minimize-error-cues.html, and as @lovemecomputer pointed out, it doesn't seem to affect our small toggle. CC @dakahn |
dakahn
left a comment
There was a problem hiding this comment.
Looks great. checked with DAP in latest chrome and the August 2018 ruleset
|
Great news - Thanks alot @dakahn for testing! |
|
🎉 This PR is included in version 6.81.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi, not sure if that's expected, but for me it's not invisible at all :)
|
|
@gdelory would you be able to provide a Code Sandbox showcasing the issue you are facing? |
|
@emyarod Please ignore this, I just double checked and I was including manually an older version of carbon-components.css (9.1 something). All my apologies for this. All looks perfect now. |
Fixes #1183.
Changelog
New
<span>in<ToggleSmall>'s<label>for assistive technologies.