This repository was archived by the owner on Oct 19, 2021. It is now read-only.
fix(Modal): avoid NPE with null check - #1756
Merged
asudoh merged 2 commits intoJan 22, 2019
Merged
Conversation
|
Deploy preview for carbon-components-react ready! Built with commit 3fdc424 https://deploy-preview-1756--carbon-components-react.netlify.com |
emyarod
force-pushed
the
1751-modal-focus-button-npe
branch
from
January 16, 2019 16:28
0520087 to
1193e00
Compare
emyarod
force-pushed
the
1751-modal-focus-button-npe
branch
from
January 21, 2019 16:02
1193e00 to
30897a6
Compare
|
🎉 This PR is included in version 6.80.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-react#1751
This PR avoids a NPE in
<Modal />by performing a null check on the focus button before chaining the.querySelectormethod