This repository was archived by the owner on Oct 19, 2021. It is now read-only.
Conversation
|
Deploy preview for carbon-components-react ready! Built with commit 35052ec https://deploy-preview-1718--carbon-components-react.netlify.com |
asudoh
reviewed
Jan 8, 2019
| </Downshift> | ||
| ); | ||
| return title || helper ? ( | ||
| <FormItem> |
Contributor
There was a problem hiding this comment.
While <FormItem> wrapping is something nice to consider in future, I'd be reluctant to change the behavior by title/helper existence. Wondering if we can use a fragment for now.
Member
Author
There was a problem hiding this comment.
sure @asudoh, originally this was done to match the markup that we have commonly used throughout the repo but I have changed it to be a fragment now
emyarod
force-pushed
the
1706-dropdownv2-title-and-helper-text
branch
from
January 11, 2019 17:24
c1d3a98 to
292879e
Compare
emyarod
force-pushed
the
1706-dropdownv2-title-and-helper-text
branch
2 times, most recently
from
January 16, 2019 16:24
3d523d0 to
96199bd
Compare
emyarod
force-pushed
the
1706-dropdownv2-title-and-helper-text
branch
from
January 21, 2019 15:58
96199bd to
63b7eef
Compare
|
🎉 This PR is included in version 6.80.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IBM/carbon-components-react#1706
This PR adds optional props to
DropdownV2for a title and helper text.Changelog
New
titleTextandhelperTextprops