Card pattern title height - #5832
Merged
Merged
Conversation
petesfrench
force-pushed
the
card-pattern-title-height
branch
from
August 19, 2026 08:11
ca31fc8 to
50e7224
Compare
Skazitron
reviewed
Aug 19, 2026
Skazitron
requested changes
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Thanks for your work on this @petesfrench. It looks alright except for a small issue.
For the 4 column card, the spacing between the description text and the rule doesn't look correct.
Let me know what you think.
Contributor
|
@mattea-turic what do you think? |
|
@Skazitron @petesfrench Hi! Referencing the 4-col card that doesn't use the image, would it be possible to use that same spacing? Right now, there seems to be too much space above the title, and too little below.
|
|
LGTM @petesfrench ! |
Skazitron
reviewed
Aug 21, 2026
Skazitron
requested changes
Aug 21, 2026
Skazitron
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me for the most part. I've left a small comment about the threshold -- which needs to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Done
fly-by:
QA
p-content-card__bodysections despite differing lengths of hover text.Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]