Conversation
Adds a hero-scoped override rule inside the vf-p-section mixin so .p-section--hero .p-chip--branded uses an 8px icon-to-text gap ($sph--small), matching the hero spacing spec. The shared .p-chip--branded rule in _patterns_chip.scss (4px gap) is left untouched, so the chip's default spacing elsewhere is unaffected.
…ants Add chip_text/chip_aria_label params and a _hero_chip_block() sub-macro to vf_hero.jinja, wired after the subtitle in all four layout branches (fallback, full-width/50-50-no-image, 25/75 signpost, default). Chip markup reuses the existing p-chip--branded pattern with the circle-of-friends icon. New params default to empty so existing hero callers render unchanged. Adds templates/docs/examples/patterns/hero/hero-with-chip.html as a render check / doc example.
Add a Chip row to the hero elements table and a "With Ubuntu Pro chip" section linking to the hero-with-chip embedded example.
Contributor
Author
|
cc @eliman11 Can you take a look? |
|
LGTM thanks @Onibenjo! Tagging @mattea-turic for a review too. This is the demo page with all the variants - https://vanilla-framework-5826.demos.haus/docs/examples/patterns/hero/hero-with-chip-variants |
…H1 and H2 are in separate columns
Contributor
Author
|
Thanks for spotting, I missed that. |
|
Thanks @Onibenjo ! +1ing! |
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
chip_text/chip_aria_labelparams to thevf_heromacro, rendering the branded Ubuntu Pro chip below the subtitle across all hero layouts (50/50, full-width image, 25/75 signpost, 75/25, fallback)..p-section--hero .p-chip--branded) — the shared.p-chip--brandedrule is untouched, so this is non-breaking.hero-with-chip) and document the new params.Ticket: WD-37738
QA
Check if PR is ready for release
Feature 🎁.package.jsonversion bumped4.55.1→4.56.0(minor — new macro params, no existing API changed).releases.ymlupdated with the Hero chip entry.Screenshots
Design reference (anticipated formats and hero placement across breakpoints) provided in the ticket; the
hero-with-chipexample reproduces the "Available with Ubuntu Pro" chip below the subtitle.