Update Content Card to accept stacked_image param and for content_type to accept lists - #5819
Merged
Merged
Conversation
muhammad-ali-pk
left a comment
Contributor
There was a problem hiding this comment.
Looks good! A few comments
Contributor
|
@petesfrench
Thanks for adding the combined stacked image example. Sorry if my previous comment was ambiguous, but I meant adding a page with all examples combined. For example: https://github.com/canonical/vanilla-framework/blob/main/templates/docs/examples/patterns/tiered-list/combined.html
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Updates the Content card pattern to full the needs outlined in this Figma design.
Content card
stacked_imageparameter to force image to be above content on individual cardscontent_typefooter field now accepts a list of strings, rendering each item as a separate read-only chipFixes https://warthogs.atlassian.net/browse/WD-37306
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]