Feat: added 8-column card for card pattern - #5809
immortalcodes merged 8 commits into
Conversation
|
Thanks Madhur - copying my comments from the other PR:
I mocked up the different variations here if it's helpful |
|
Reviewed this with @mattea-turic and had the following comments -
|
|
Thanks @eliman11 @mattea-turic
|
|
Thanks so much @immortalcodes! Just one more tiny change, can we reverse the order the information appears on tablet and mobile to image -> heading -> author/date -> description? To stay consistent with the way the other card variants resize on tablet and mobile. Thanks a lot!
|
Sorry but is it not already the case? |
|
@immortalcodes hm maybe the changes didn't load for me yesterday. LGTM then :) |
|
+1ing too as Elaine and I shared the same comments |
ea82274 to
30f2392
Compare


Done
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]