Sitelet https://github.com/canonical/vanilla-framework/pull/5809
Skip to content

Feat: added 8-column card for card pattern - #5809

Merged
immortalcodes merged 8 commits into
mainfrom
WD-36957-create-8-column-card-pattern-on-vanilla-framework
Jun 12, 2026
Merged

immortalcodes merged 8 commits into
mainfrom
WD-36957-create-8-column-card-pattern-on-vanilla-framework

Conversation

@immortalcodes

@immortalcodes immortalcodes commented Jun 4, 2026 •

Copy link
Copy Markdown
Member

Done

  • Added 8-column card for card pattern
  • Added relevant docs

QA

  • Open demo
  • See the docs and example and ensure they match the design .

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app

Copy link
Copy Markdown

@eliman11

eliman11 commented Jun 5, 2026 •

Copy link
Copy Markdown

Thanks Madhur - copying my comments from the other PR:

  • Use h1 styling for the article heading
  • Limit the title to 3 lines as we've done with the other card and showing the description for the featured article without having to hover over it (but keeping the hover interaction with the card border the same)

I mocked up the different variations here if it's helpful

@eliman11

eliman11 commented Jun 8, 2026

Copy link
Copy Markdown

Reviewed this with @mattea-turic and had the following comments -

  • The line height (i.e. the space between each line) in the heading looks to be bigger than Vanilla
  • Perhaps with this ^ fix, we can keep the description to 3 lines instead of 2
  • Also mocked up the tablet and mobile versions with author, date and description here

@immortalcodes

immortalcodes commented Jun 9, 2026 •

Copy link
Copy Markdown
Member Author

Thanks @eliman11 @mattea-turic
Made changes as suggested in the comment

  • For the line-height, this was something already there in the styling for the card heading, are you sure we need less of it now?

@eliman11

eliman11 commented Jun 9, 2026

Copy link
Copy Markdown

Thanks so much @immortalcodes! Just one more tiny change, can we reverse the order the information appears on tablet and mobile to image -> heading -> author/date -> description? To stay consistent with the way the other card variants resize on tablet and mobile. Thanks a lot!

Screenshot 2026-06-09 at 14 51 20

@immortalcodes

Copy link
Copy Markdown
Member Author

Thanks so much @immortalcodes! Just one more tiny change, can we reverse the order the information appears on tablet and mobile to image -> heading -> author/date -> description? To stay consistent with the way the other card variants resize on tablet and mobile. Thanks a lot!

Screenshot 2026-06-09 at 14 51 20

Sorry but is it not already the case?

Comment thread templates/_macros/vf_card.jinja Outdated
Comment thread releases.yml Outdated
Comment thread templates/docs/patterns/content-card/index.md Outdated
Comment thread templates/docs/examples/patterns/content-card/8-column.html
@eliman11

Copy link
Copy Markdown

@immortalcodes hm maybe the changes didn't load for me yesterday. LGTM then :)

@mattea-turic

Copy link
Copy Markdown

+1ing too as Elaine and I shared the same comments

@immortalcodes
immortalcodes force-pushed the WD-36957-create-8-column-card-pattern-on-vanilla-framework branch from ea82274 to 30f2392 Compare June 11, 2026 08:43
@immortalcodes
immortalcodes requested a review from Skazitron June 11, 2026 12:51

@Skazitron Skazitron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immortalcodes
immortalcodes merged commit 63878be into main Jun 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants