Sitelet https://github.com/canonical/vanilla-framework/pull/5802
Skip to content

fix(docs): Fix version number in CDN link being malformatted - #5802

Merged
jmuzina merged 2 commits into
canonical:mainfrom
jmuzina:WD-36205-cdn-link
May 8, 2026
Merged

jmuzina merged 2 commits into
canonical:mainfrom
jmuzina:WD-36205-cdn-link

Conversation

@jmuzina

@jmuzina jmuzina commented May 7, 2026 •

Copy link
Copy Markdown
Member

Done

Changes formatting of the Vanilla URL in CDN links to use dots inside the version number instead of underscores

Fixes #5793
Fixes https://warthogs.atlassian.net/browse/WD-36205
Fixes https://chat.canonical.com/canonical/pl/dwo4wuwarib3dm86bjxuik11pw

QA

  • Open demo
  • Open the getting started page
  • Verify the CDN url (when the version is replaced with 4.50.0 instead of 4.51.0) does not 404

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

@webteam-app

Copy link
Copy Markdown

@bartaz

bartaz commented May 7, 2026

Copy link
Copy Markdown
Contributor

It does work, but the current version of Vanilla is 4.51 already, so on demos the link doesn't work.
So we just need to make sure we don't just redeploy the site, but the full release is needed.

@bartaz bartaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with caveat in comment above.

There is an unreleased version of Vanilla 4.51, that needs to be released before this change is deployed to the website.

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels May 8, 2026
@jmuzina
jmuzina merged commit 74d7505 into canonical:main May 8, 2026
8 checks passed
@jmuzina
jmuzina deleted the WD-36205-cdn-link branch May 8, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Vanilla Framework 4.49.0 ~ Minified CSS not available in assets.ubuntu.com

3 participants