Integrate UIElements support and ShowFullNamespace option - #3
Open
canoide wants to merge 4 commits into
Open
Conversation
- Added UIElements support to SubclassSelectorDrawer via CreatePropertyGUI. - Added ShowFullNamespace property to SubclassSelectorAttribute. - Updated AdvancedTypePopup to support displaying full namespace hierarchy. - Improved SubclassSelectorDrawer drawing logic for both IMGUI and UIElements. - Fixed infinite recursion in GetPropertyHeight. - Fixed listener leaks in CreatePropertyGUI using TrackPropertyValue. Co-authored-by: canoide <5910326+canoide@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added UIElements support to SubclassSelectorDrawer via CreatePropertyGUI. - Added ShowFullNamespace property to SubclassSelectorAttribute. - Updated AdvancedTypePopup to support displaying full namespace hierarchy. - Improved SubclassSelectorDrawer drawing logic for both IMGUI and UIElements. - Fixed infinite recursion in GetPropertyHeight by using manual children height calculation. - Fixed listener leaks in CreatePropertyGUI using TrackPropertyValue. - Maintained modern GitHub Actions workflows and Unity versions from main. Co-authored-by: canoide <5910326+canoide@users.noreply.github.com>
- Added UIElements support to SubclassSelectorDrawer via CreatePropertyGUI. - Added ShowFullNamespace property to SubclassSelectorAttribute. - Updated AdvancedTypePopup to support displaying full namespace hierarchy. - Improved SubclassSelectorDrawer drawing logic for both IMGUI and UIElements. - Fixed infinite recursion in GetPropertyHeight by using manual children height calculation. - Fixed listener leaks in CreatePropertyGUI using TrackPropertyValue. - Restored modern GitHub Actions workflows and Unity versions from main. - Corrected preprocessor directives for IMGUI layout compatibility. Co-authored-by: canoide <5910326+canoide@users.noreply.github.com>
- Integrated CreatePropertyGUI for UI Toolkit support. - Added ShowFullNamespace property to SubclassSelectorAttribute. - Fixed recursion bug in GetPropertyHeight. - Optimized resource management in UIElements via TrackPropertyValue. - Restored and verified modern GitHub Actions and Unity versions. - Ensured IMGUI layout compatibility via preprocessor fixes. Co-authored-by: canoide <5910326+canoide@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have integrated the features from the
origin/feature/uielements-support-13734061030980915401branch into the current architecture.Key changes:
SubclassSelectorDrawernow implementsCreatePropertyGUI, allowing it to work in the modern Unity UI Toolkit. It includes a foldout for child properties and respects custom property drawers.ShowFullNamespaceproperty has been added toSubclassSelectorAttribute. When enabled, the type selection popup will show the complete namespace hierarchy instead of flattening single-namespace structures.GetPropertyHeightthat would cause aStackOverflowException.TrackPropertyValuefor UI refreshes.UseToStringAsLabelis respected in both IMGUI and UI Toolkit.TypeSearchServicearchitecture while bringing in the new features.PR created automatically by Jules for task 15563507361962814745 started by @canoide