Sitelet https://github.com/calcom/cal.diy/pull/30019
Skip to content

fix: Release status: v6.2.0 is impractical for self-hosted multi-user use whi... - #30019

Open
Roshan931 wants to merge 1 commit into
calcom:mainfrom
Roshan931:prilog/fix-error-features-list-served-from-deprecated-08-21-2026-c7cfb6
Open

fix: Release status: v6.2.0 is impractical for self-hosted multi-user use whi...#30019
Roshan931 wants to merge 1 commit into
calcom:mainfrom
Roshan931:prilog/fix-error-features-list-served-from-deprecated-08-21-2026-c7cfb6

Conversation

@Roshan931

@Roshan931 Roshan931 commented Aug 21, 2026

Copy link
Copy Markdown

Fixes #30013

Root cause

features.list served from deprecated FeaturesRepository static 5-minute cache that flag mutations never invalidate

Changes

  • Serve viewer.features.list from the cache-invalidating FeatureRepository (CachedFeatureRepository, whose cache is busted by the toggleFeatureFlag mutation) instead of the deprecated FeaturesRepository static in-memory cache, plus a regression test asserting the delegation.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Welcome to Cal.diy, @Roshan931! Thanks for opening this pull request.

A few things to keep in mind:

  • This is Cal.diy, not Cal.com. Cal.diy is a community-driven, fully open-source fork of Cal.com licensed under MIT. Your changes here will be part of Cal.diy — they will not be deployed to the Cal.com production app.
  • Please review our Contributing Guidelines if you haven't already.
  • Make sure your PR title follows the Conventional Commits format.

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added the 🐛 bug Something isn't working label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14631070-6ab8-4518-8503-f85ff96a273e

📥 Commits

Reviewing files that changed from the base of the PR and between 176037d and 52724c1.

📒 Files selected for processing (1)
  • packages/trpc/server/routers/features/_router.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The feature flag list query now imports the singular feature repository. It obtains that repository and returns results from findAll() instead of calling getAllFeatures() on the plural repository.

Merge Risk: ⚪ Minimal · up to 52724

This localized change makes feature-list reads use the cache-invalidating repository so flag updates are reflected correctly; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title relates to the linked self-hosting issue but describes the broader release problem rather than the feature-cache fix.
Description check ✅ Passed The description clearly explains the stale feature flag cache and the repository change that fixes it.
Linked Issues check ✅ Passed The repository change addresses the linked issue's feature flag caching problem by using the cache-invalidating FeatureRepository.
Out of Scope Changes check ✅ Passed The changes are limited to the feature list repository delegation and directly support the linked feature flag caching objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

CLAassistant commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🐛 bug Something isn't working size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release status: v6.2.0 is impractical for self-hosted multi-user use while main already fixes key issues

2 participants

@Roshan931 @CLAassistant