[stack-switching] Bounds-check continuation payload writes - #14540
Merged
Merged
Conversation
This patch adds a defensive check in `occupy_next_slot`, ensuring that a continuation's data buffer has sufficient capacity. I believe a well-typed Wasm program should never be able to fail this check, thus failing it ought to indicate some external tampering with continuation objects.
alexcrichton
reviewed
Oct 5, 2026
alexcrichton
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a defensive check in
occupy_next_slot, ensuring that a continuation's data buffer has sufficient capacity. I believe a well-typed Wasm program should never be able to fail this check, thus failing it ought to indicate some external tampering with continuation objects.Resolves #13028. Note the root cause in #13028 was fixed by PR#11717. This PR resolves the issue in the sense that it adds the defensive suggestion outlined in the issue.