fix(core): let fetch compute content length - #212
Open
edenbuilds wants to merge 1 commit into
Open
edenbuilds wants to merge 1 commit into
edenbuilds wants to merge 1 commit into
Conversation
Do not send an explicit content-length header from the SDK. Fetch and undici already compute it from the request body, and an explicit value can collide with the computed header when consumers install a custom global dispatcher. Fixes browserbase#197
Author
|
Checking in on this one. It is mergeable against current main and its checks pass. Happy to change the approach if you prefer a different shape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content-lengthheader to SDK requests.Verification
content-lengthwas present.tests/index.test.ts: 31/31 passed after the fix.Fixes #197