Repository navigation
Updating README to include information about how we publish this fork. - #3
Open
lbergelson wants to merge 2 commits into
Open
lbergelson wants to merge 2 commits into
lbergelson wants to merge 2 commits into
Conversation
droazen
suggested changes
Aug 10, 2018
| In order to build and publish the **google-cloud-nio** artifact to central: | ||
| ``` | ||
| cd google-cloud-contrib/google-cloud-nio/ | ||
| mvn clean deploy -Dcheckstyle.skip=true -DskipTests |
There was a problem hiding this comment.
Would be good to add instructions for setting up the sonatype authentication as well.
| @@ -1,3 +1,13 @@ | |||
| ### This is a fork to work around https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2453 | |||
There was a problem hiding this comment.
I would flesh this out a bit more:
This is a fork of https://github.com/GoogleCloudPlatform/google-cloud-java built
upon a version not affected by the bug described in https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2453, and
with various retry-related patches applied to the `google-cloud-nio` package
that are needed by downstream projects such as https://github.com/broadinstitute/gatk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.