Sitelet https://github.com/broadinstitute/google-cloud-java/pull/3
Skip to content

Updating README to include information about how we publish this fork. - #3

Open
lbergelson wants to merge 2 commits into
masterfrom
lb_update_readme
Open

lbergelson wants to merge 2 commits into
masterfrom
lb_update_readme

Conversation

@lbergelson

Copy link
Copy Markdown

No description provided.

@droazen droazen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, otherwise looks good.

Comment thread README.md
In order to build and publish the **google-cloud-nio** artifact to central:
```
cd google-cloud-contrib/google-cloud-nio/
mvn clean deploy -Dcheckstyle.skip=true -DskipTests

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add instructions for setting up the sonatype authentication as well.

Comment thread README.md Outdated
@@ -1,3 +1,13 @@
### This is a fork to work around https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2453

@droazen droazen Aug 10, 2018 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would flesh this out a bit more:

This is a fork of https://github.com/GoogleCloudPlatform/google-cloud-java built 
upon a version not affected by the bug described in https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2453, and 
with various retry-related patches applied to the `google-cloud-nio` package 
that are needed by downstream projects such as https://github.com/broadinstitute/gatk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants