Sitelet https://github.com/bandframework/bandframework/pull/131
Skip to content

BAND v04 - #131

Merged
DanielRPhillips merged 319 commits into
mainfrom
develop
Oct 2, 2024
Merged

DanielRPhillips merged 319 commits into
mainfrom
develop

Conversation

@wildsm

@wildsm wildsm commented Sep 18, 2024 •

Copy link
Copy Markdown
Member

This is a draft PR with staging for the bandframework v0.4 release.

The working checklist is from the updated release process in develop (https://github.com/bandframework/bandframework/blob/develop/resources/dev_guide/release-proc.rst).

BAND Framework Release Process

A release can be undertaken only by a project administrator.
A project administrator should have an administrator role on the bandframework GitHub <https://github.com/bandframework>_.

Best practice is to follow the version of this process as recorded on the develop and/or release branch(es).

Before release

  • A GitHub issue is created with a checklist for the release.

  • A release branch should be taken off develop (or develop pulls
    controlled).

  • Release notes for this version are added to the CHANGELOG.rst </CHANGELOG.rst>_ file.

    • Confirmed
  • Ensure that links and references have been updated (e.g., no occurrences of privateband).

    • grep shows no unexpected privateband occurrences in develop:
./.github/config/.wordlist.txt:privateband
./resources/dev_guide/release-proc.rst:- Ensure that links and references have been updated (e.g., no occurrences of ``privateband``).
./CHANGELOG.rst:- improve documentation and facilitation of migration from privateband and bandframework branches to bandframework
./CHANGELOG.rst:- improve documentation and facilitation of migration from privateband and bandframework branches to bandframework
./CHANGELOG.rst:- improve documentation and facilitation of migration from privateband and bandframework branches to bandframework
  • Version number is updated wherever it appears and +dev suffix is removed
    (in README.md </README.md>_ and possibly in CHANGELOG.rst </CHANGELOG.rst>_).

    • Confirmed (after reviewer comments in this PR)
  • Check README.md </README.md>_ Citing bandframework for correctness (e.g., ensure that author list matches AUTHORS </AUTHORS>_).

    • This is confirmed; all author lists were updated for v0.4.
  • Check bandsdk.md </resources/sdkpolicies/bandsdk.md>_ Citing bandframework for correctness. Ensure that SDK version listed is the same as in the provided template </resources/sdkpolicies/template.md>_.

    • Confirmed by reviewers
  • Check sdkpolicies README </resources/sdkpolicies/README.md>_ for correctness (e.g., ensure that each software in the release has a working link for its SDK compliance, also note any differences in the version of the SDK that each package lists versus the version at bandsdk.md </resources/sdkpolicies/bandsdk.md>_).

  • Tests are run with source to be released (this may iterate):

    • Online CI (GitHub Actions) tests must pass.

    • Documentation must build and display correctly wherever hosted.

  • Pull request from either the develop or release branch to main requesting
    one or more reviewers (including at least one other administrator).

  • Reviewer will check that all tests have passed and will then approve merge.

  • Send an email to bandframework@cels.anl.gov asking to confirm whether the list of email contacts in CODE_OF_CONDUCT.md </CODE_OF_CONDUCT.md>_ is up-to-date.

    • All 5 individuals listed have confirmed things are working as expected

During release

An administrator will take the following steps.

  • Merge the pull request into main.

  • Once CI tests have passed on main:

    • A GitHub release will be taken from the main.
  • If the merge was made from a release branch (instead of develop), merge this
    branch into develop.

  • Create a new commit on develop that appends +dev to the version number
    (wherever it appears).

After release

  • Ensure all relevant GitHub issues are closed.

  • Update website to reflect existence of new release.

  • Disseminate news of new release to: FRIB-TA mailing list, JETSCAPE/X-SCAPE mailing list, other interested parties.

Added SmoothEmulator authors
Added SmoothEmulator authors
@wildsm
wildsm marked this pull request as ready for review September 27, 2024 15:21
wildsm and others added 4 commits September 27, 2024 08:49
Corrected two links in CHANGELOG (because it is rst not md)
minor change in readme
Documentation associated with the v0.4 release
adding periods
@ozgesurer

Copy link
Copy Markdown
Collaborator

I have reviewed the develop branch and confirmed that all links are working properly. I also checked the SDK links and verified the numbers. Additionally, I created one more PR to add two periods to the README. @wildsm, after merging the documentation branch into develop, a reviewer is required for the changes.

I believe the only remaining task is to update the version number wherever it appears and remove the +dev suffix before merging into the main. Let me know if you’d like me to handle this.

@ozgesurer ozgesurer assigned ozgesurer and unassigned ozgesurer Sep 28, 2024
@wildsm

wildsm commented Sep 28, 2024

Copy link
Copy Markdown
Member Author

I have reviewed the develop branch and confirmed that all links are working properly. I also checked the SDK links and verified the numbers. Additionally, I created one more PR to add two periods to the README. @wildsm, after merging the documentation branch into develop, a reviewer is required for the changes.

I believe the only remaining task is to update the version number wherever it appears and remove the +dev suffix before merging into the main. Let me know if you’d like me to handle this.

@ozgesurer - Thanks! To confirm: the 'one more PR' has already been merged into develop, correct?

@ozgesurer

Copy link
Copy Markdown
Collaborator

I have reviewed the develop branch and confirmed that all links are working properly. I also checked the SDK links and verified the numbers. Additionally, I created one more PR to add two periods to the README. @wildsm, after merging the documentation branch into develop, a reviewer is required for the changes.
I believe the only remaining task is to update the version number wherever it appears and remove the +dev suffix before merging into the main. Let me know if you’d like me to handle this.

@ozgesurer - Thanks! To confirm: the 'one more PR' has already been merged into develop, correct?

Yes, Moses approved it.

DanielRPhillips and others added 10 commits September 30, 2024 21:08
Changed description of BAND examples
Re-factored tools & examples to try and align with new definition thereof.
Fixed typo; re-ordered tools according to BAND workflow; re-ordered examples alphabetically
Documentation and overall changes for v0.4
Changing release date

@DanielRPhillips DanielRPhillips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the top level changes to bandframework and approve the merge.

@DanielRPhillips
DanielRPhillips merged commit e720271 into main Oct 2, 2024
wildsm added a commit that referenced this pull request Oct 2, 2024
Merge pull request #131 from bandframework/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants