Test register-hooks usage in Pirates - #18007
Open
Aditi-1400 wants to merge 1 commit into
Open
Aditi-1400 wants to merge 1 commit into
Aditi-1400 wants to merge 1 commit into
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61627 |
|
commit: |
Aditi-1400
force-pushed
the
test-pirates-register-hooks
branch
2 times, most recently
from
May 21, 2026 00:33
93cb243 to
109d315
Compare
Member
|
The angular failure is unrelated -- it seems like all tests are now passing on all Node.js versions :) |
Aditi-1400
force-pushed
the
test-pirates-register-hooks
branch
from
May 25, 2026 11:38
109d315 to
ed82c53
Compare
Aditi-1400
force-pushed
the
test-pirates-register-hooks
branch
from
May 25, 2026 17:55
ed82c53 to
13b7327
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to test whether the migration of the package Pirates to Node
[module.registerHooks()](https://github.com/nodejs/node/issues/56241)works as expected without any breaking changes, this temporarily changes the pirates to point to the register hooks branch of my fork, more details about the migration in the PR here: danez/pirates#130