Sitelet https://github.com/aws/aws-toolkit-vscode/pull/8856
Skip to content

feat(cloudformation): Harden CloudFormation language-server installat… - #8856

Open
satyakigh wants to merge 3 commits into
aws:masterfrom
satyakigh:cfn-lsp
Open

feat(cloudformation): Harden CloudFormation language-server installat…#8856
satyakigh wants to merge 3 commits into
aws:masterfrom
satyakigh:cfn-lsp

Conversation

@satyakigh

Copy link
Copy Markdown
Contributor

…ion, caching, cleanup, and startup recovery while simplifying the installer abstraction layer

Problem

LSP downloads were inconsistent and insafe

Solution

  • Resolve the highest compatible, non-delisted version for the current target.
  • Adapt alpha, beta, and prod manifests only in the concrete CloudFormation adapter.
  • Retry manifest and bundle downloads three times with exponential backoff.
  • Parse manifests before atomic caching and fall back to the cached manifest when necessary.
  • Validate hashes and required files before publication and again after post-install processing.
  • Safely extract archives, delete ZIP files, and handle concurrent atomic publication.
  • Retain the active version and highest valid fallback.
  • Invalidate a failed managed installation and retry startup once.
  • Replace the one-method ManifestProvider hierarchy with ResolveManifest function injection.
  • Guard the cfn-init permission update when the optional executable is absent.
  • Correct stale HttpResourceFetcher documentation.
  • Preserve explicit restart and deactivation cleanup for client-session resources.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ion, caching, cleanup, and startup recovery while simplifying the installer abstraction layer
@satyakigh
satyakigh requested a review from a team August 19, 2026 05:52
@amazon-inspector-ohio

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions

Copy link
Copy Markdown
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant