Sitelet https://github.com/aws/aws-cli/pull/1126
Skip to content

Disable paramfile for sqs purge-queue - #1126

Merged
jamesls merged 3 commits into
aws:developfrom
jamesls:sqs-purge-queue-fix
Feb 6, 2015
Merged

jamesls merged 3 commits into
aws:developfrom
jamesls:sqs-purge-queue-fix

Conversation

@jamesls

@jamesls jamesls commented Feb 4, 2015

Copy link
Copy Markdown
Member

Valid values for this param will be https so we need to disable paramfile processing.

cc @kyleknap @danielgtaylor

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 91.76% when pulling 4d9c2b6 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.13%) to 91.62% when pulling 18f33c2 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.01%) to 91.76% when pulling 18f33c2 on jamesls:sqs-purge-queue-fix into 7350250 on aws:develop.

@jamesls

jamesls commented Feb 4, 2015

Copy link
Copy Markdown
Member Author

Coveralls makes no sense here. I think I should be ok test coverage, I added a test for this.

@kyleknap

kyleknap commented Feb 4, 2015

Copy link
Copy Markdown
Contributor

Yeah its fine. 🚢

@jamesls
jamesls merged commit 18f33c2 into aws:develop Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants