Fix intermittent OAuth state retrieval failure - #248
Open
Sumit-hubgit wants to merge 1 commit into
Open
Sumit-hubgit wants to merge 1 commit into
Sumit-hubgit wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Authomatic intermittently fails on the first Google OAuth login attempt with
"Unable to retrieve stored state!", while retry succeeds.
This happens when the OAuth state (csrf) stored in the session is temporarily
missing during the redirect callback, even though Google returns a valid
response.
What I changed
I updated the OAuth2 login flow to safely handle this case. Instead of failing
immediately when the stored state is missing, the code now recovers the state
from the OAuth callback and saves it back to the session.
The existing state comparison logic is preserved, so mismatched or forged
states are still rejected.
Why this works
The missing state is caused by session or cookie timing issues, not by an
invalid Google response. Recovering the state prevents false login failures
without weakening CSRF protection.
Scope