Conversation
jensens
approved these changes
Nov 7, 2024
jensens
reviewed
Nov 7, 2024
| keys = json.loads(result).get("keys") | ||
|
|
||
| if not isinstance(keys, list) or not keys: | ||
| raise |
Member
There was a problem hiding this comment.
pylint does not like a bare raise here.
py3: commands[0]> pylint --errors-only --ignore=six.py authomatic
************* Module authomatic.providers.oauth2
authomatic/providers/oauth2.py:665:12: E0704: The raise statement is not inside an except clause (misplaced-bare-raise)
py3: exit 2 (5.21 seconds) /home/runner/work/authomatic/authomatic> pylint --errors-only --ignore=six.py authomatic pid=1762
py3: FAIL code 2 (18.88=setup[13.67]+cmd[5.21] seconds)
evaluation failed :( (19.00 seconds)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been working on adding Apple as an authentication provider into Authomatic.
To do so I had to introduce 2 changes in the
OAuth2base class:PyJWTas a requirement of the package.response_modeparam, so I add a dummy method that returns nothing in the base OAuth2 class and then the method that returns what Apple requires in its own baseclass.I don't exactly know whether Apple's implementation is a fully OAuth2 compliant implementation, so I am OK if this PR is completely disregarded. I just wanted to let you know about these changes and discuss them before integrating into Authomatic.