Repository navigation
Closed
Conversation
ReactTraining/history will be changing its required import statement to use its package.
Please update code accordingly to conform for the next update.
```
warnAboutDeprecatedCJSRequire.js:17 Warning: Please use `require("history").createBrowserHistory` instead of `require("history/createBrowserHistory")`. Support for the latter will be removed in the next major release.
```
stevehobbsdev
self-requested a review
June 3, 2019 14:00
Contributor
|
@SSelke Thanks for the contribution! We have 4 other samples which would also require this change, would it be possible to patch those too in this PR? |
stevehobbsdev
pushed a commit
that referenced
this pull request
Sep 25, 2019
Also ran `npm audit fix` on all samples
Contributor
|
This has now been actioned in a new branch and tagged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReactTraining/history will be changing its required import statement to use its package.
Please update code accordingly to conform for the next update.