skip llvm-strip on signed DLLs - #1217
Merged
Merged
Conversation
`llvm-strip` removes the Authenticode signature from these DLLs, but it keeps the certificate table entry in the PE optional header. The entry then points past the end of the file. An MSIX package fails to sign when it contains one of these DLLs, because AppxSIP examines each PE file in the package, and `signtool` refuses to sign with with 0x800700C1 (ERROR_BAD_EXE_FORMAT). It still happens with the Tcl/Tk 8.6 DLLs (CPython 3.10 to 3.13, all Windows targets) and in vcruntime140_threads.dll (CPython 3.10). CPython 3.14 and later use Tcl 9, which astral-sh#1213 exempted for a different reason.
ethernet8023
added a commit
to NousResearch/hermes-agent
that referenced
this pull request
Aug 12, 2026
remove this after astral-sh/python-build-standalone#1217 is merge
Contributor
|
This makes sense. These DLLs are coming pre-build (and signed) from CPython via https://github.com/python/cpython-bin-deps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when packaging a
uv pythoninstalled python into a .msix app for the microsoft app store, i hit somesigntoolfailures with error0x800700C1.these are caused by
AppxSIPgoing thru every binary in your package and validating them in some way.llvm-stripremoves the signature from a bunch of DLLs that come with these python buidls, but it keeps the certificate table entry in the PE optional header , which makes the entry point past the end of the file.this is exactly the bug from #855 that #856 solved. i'm extending it to more DLLs and adding a comment explaining it.
a more permanent fix might be detecting signatures on files and skipping if we see them? let me know if you'd rather that, i could wireup detecting signatures and/or zipfs to get rid of the hardcoded list that'll probably regress as versions change what DLLs are shipped.