Convert Javadoc to Markdown on assertj-tests modules - #4295
Open
barbulescu wants to merge 1 commit into
Open
Conversation
✅ All tests passed ✅🏷️ Commit: 89782d0 Learn more about TestLens at testlens.app. |
Member
|
Hi @barbulescu, thanks a lot for raising this! AFAIK, what should matter is only the Java version at build time, not the language level we target. This means we can do the same for all other modules, and we might also consider targeting I'll double-check my assumption and apply your changes either in |
Member
|
FYI, to make sure I'm not clashing with your work, I started experimenting with the Guava module in #4298. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work on #3977 on modules supporting Java 23+.
Most of the changes were done with Openrewrite with several bugs fixed on the way.
Initial review was done by Claude followed by several fixes and a final manual review.
Blocked by:
assertj-guava#4298