Repository navigation
Conversation
A recursive call instantiates the summary being computed, mapping its summary choices to fresh call choices, and exporting the caller's summary renames those to new summary choices. Each fixed-point iteration therefore added the previous iteration's choices (two per iteration for a `mut self` method that writes a ByteBuffer in a loop and recurses), and the summary query hit its 16-iteration limit with "recursive boundary requirements did not converge". Before numbering summary choices, quantify the choices of calls to the instance being summarized existentially in boundary and availability requirements, memory accesses, unavailable regions and native requirements. These are obligations or possible effects: a caller cannot observe the callee's private choices and must handle every execution anyway, as for loan requirements and repeated loop iterations. Must facts (reinitialized regions, poststates, coverage) and authorizers keep the choices. Only direct self-recursion is widened; mutual recursion is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e92a34ad1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for region in self | ||
| .requirements | ||
| .iter_mut() | ||
| .map(|requirement| &mut requirement.region) |
There was a problem hiding this comment.
When a recursive call's conditionally populated borrowed value is later stored, the corresponding BoundaryRequirement::populated region can retain that call's CallChoice guards. This loop only projects requirement.region, although abstract_choices subsequently renames both regions; the populated guard is therefore reimported under a fresh choice on the next fixed-point iteration and can still trigger recursive boundary requirements did not converge. Include requirement.populated in the recursive-choice projection as well.
Useful? React with 👍 / 👎.
A recursive call instantiates the summary being computed, mapping its summary choices to fresh call choices, and exporting the caller's summary renames those to new summary choices. Each fixed-point iteration therefore added the previous iteration's choices (two per iteration for a
mut selfmethod that writes a ByteBuffer in a loop and recurses), and the summary query hit its 16-iteration limit with "recursive boundary requirements did not converge".Before numbering summary choices, quantify the choices of calls to the instance being summarized existentially in boundary and availability requirements, memory accesses, unavailable regions and native requirements. These are obligations or possible effects: a caller cannot observe the callee's private choices and must handle every execution anyway, as for loan requirements and repeated loop iterations. Must facts (reinitialized regions, poststates, coverage) and authorizers keep the choices.
Only direct self-recursion is widened; mutual recursion is unchanged.