Sitelet https://github.com/appium/python-client/pull/889
Skip to content

chore: update isort revision to 5.12.0 - #889

Merged
KazuCocoa merged 1 commit into
appium:masterfrom
Dor-bl:isort_rev
Jul 8, 2023
Merged

chore: update isort revision to 5.12.0#889
KazuCocoa merged 1 commit into
appium:masterfrom
Dor-bl:isort_rev

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

using isort revision 5.10.1 raise an error when trying to commit a change:

line 58, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

      [end of output]

once I updated isort to 5.12.0, the error is gone.

KazuCocoa
KazuCocoa reviewed Jul 8, 2023
View reviewed changes
Comment thread .pre-commit-config.yaml
repos:
- repo: https://github.com/PyCQA/isort
rev: 5.10.1
rev: 5.12.0

@KazuCocoa KazuCocoa Jul 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check if we can remove this line since we basically manage versions in

python-client/Pipfile

Line 9 in b142e00

isort = "<6.0"
. I guess this version can be removed. (but it is not this pr)

@KazuCocoa
KazuCocoa merged commit 2853ac0 into appium:master Jul 8, 2023
@Dor-bl
Dor-bl deleted the isort_rev branch July 8, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dor-bl @KazuCocoa