Sitelet https://github.com/appium/python-client/pull/859
Skip to content

refactor: Move driver-specific commands to use extensions (part2) - #859

Merged
mykola-mokhnach merged 6 commits into
appium:masterfrom
mykola-mokhnach:android_exts
May 7, 2023
Merged

mykola-mokhnach merged 6 commits into
appium:masterfrom
mykola-mokhnach:android_exts

Conversation

@mykola-mokhnach

Copy link
Copy Markdown
Contributor

No description provided.

@mykola-mokhnach
mykola-mokhnach requested a review from KazuCocoa May 4, 2023 15:18
@KazuCocoa

Copy link
Copy Markdown
Member

will take a look later

@mykola-mokhnach
mykola-mokhnach deleted the android_exts branch May 6, 2023 09:58
@mykola-mokhnach
mykola-mokhnach restored the android_exts branch May 6, 2023 10:00
def start_activity(self, app_package: str, app_activity: str, **opts: str) -> 'WebDriver':
"""Opens an arbitrary activity during a test. If the activity belongs to
another application, that application is started and the activity is opened.
deprecated:: 2.0.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this 2.0.0 mean this client library?
Current one is 2.9.0, so 3.0.0?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not quite sure what to put there. I assume it should be the current version, so will change it to 2.9.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha

@mykola-mokhnach
mykola-mokhnach merged commit d988f3c into appium:master May 7, 2023
@mykola-mokhnach
mykola-mokhnach deleted the android_exts branch May 7, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants