Sitelet https://github.com/appium/python-client/pull/567/files
Skip to content

feat: add warning to drop forceMjsonwp for W3C #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 7 commits into from
Dec 21, 2020
Merged

feat: add warning to drop forceMjsonwp for W3C #567

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb84d48
tweak
KazuCocoa Dec 19, 2020
a6e9bba
Merge branch 'master' into drop-forcemjsonwp
KazuCocoa Dec 20, 2020
dd1fa80
fix test
KazuCocoa Dec 20, 2020
dfff196
print warning
KazuCocoa Dec 20, 2020
608d10d
revert test
KazuCocoa Dec 20, 2020
1c5f1c4
Update webdriver.py
KazuCocoa Dec 21, 2020
d987d9e
fix autopep8
KazuCocoa Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ def _merge_capabilities(self, capabilities: Dict) -> Dict[str, Any]:
"""Manage capabilities whether W3C format or MJSONWP format
"""
if _FORCE_MJSONWP in capabilities:
logger.warning("[Deprecated] 'forceMjsonwp' capability will be dropped after switching base selenium client from v3 to v4 "
"to follow W3C spec capabilities. Appium 2.0 will also support only W3C session creation capabilities.")
force_mjsonwp = capabilities[_FORCE_MJSONWP]
del capabilities[_FORCE_MJSONWP]

Expand Down