Sitelet https://github.com/appium/python-client/pull/1071
Skip to content

feat: Added typing for AppiumBy - #1071

Merged
KazuCocoa merged 4 commits into
appium:masterfrom
Brijeshkrishna:typing_for_appiumby
Nov 29, 2024
Merged

feat: Added typing for AppiumBy#1071
KazuCocoa merged 4 commits into
appium:masterfrom
Brijeshkrishna:typing_for_appiumby

Conversation

@Brijeshkrishna

@Brijeshkrishna Brijeshkrishna commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

Adding typing annotations for AppiumBy types

@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 28, 2024 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

mykola-mokhnach
mykola-mokhnach reviewed Nov 28, 2024
View reviewed changes
Comment thread appium/webdriver/common/appiumby.py Outdated
mykola-mokhnach
mykola-mokhnach reviewed Nov 28, 2024
View reviewed changes
Comment thread appium/webdriver/common/appiumby.py
@Brijeshkrishna
Brijeshkrishna marked this pull request as draft November 28, 2024 19:21
@Brijeshkrishna
Brijeshkrishna marked this pull request as ready for review November 28, 2024 19:42
mykola-mokhnach
mykola-mokhnach reviewed Nov 28, 2024
View reviewed changes
Comment thread appium/webdriver/extensions/flutter_integration/flutter_finder.py Outdated
@Brijeshkrishna Brijeshkrishna changed the title feat: Added typing for AppiumBy types feat: Added typing for AppiumBy Nov 29, 2024
@mykola-mokhnach

mykola-mokhnach commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

Please make sure tests are happy: https://github.com/appium/python-client/actions/runs/12079337810/job/33689980005?pr=1071

@KazuCocoa
KazuCocoa merged commit 00e9a6e into appium:master Nov 29, 2024
@KazuCocoa KazuCocoa added size:XS contribution size: XS size:S contribution size: S and removed size:XS contribution size: XS labels Dec 2, 2024
@jlipps

jlipps commented Jan 8, 2025

Copy link
Copy Markdown
Member

Hi @Brijeshkrishna, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@Brijeshkrishna

Brijeshkrishna commented Jan 10, 2025

Copy link
Copy Markdown
Contributor Author

Hi @Brijeshkrishna, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@jlipps @KazuCocoa
This is my account https://opencollective.com/brijeshkrishna

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes
@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees

No one assigned

Labels

size:S contribution size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Brijeshkrishna @mykola-mokhnach @jlipps @KazuCocoa