-
Notifications
You must be signed in to change notification settings - Fork 570
ci: moving to GHA #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: moving to GHA #1010
Changes from all commits
5e21511
8eb3e13
1a21ba5
8fe0680
102bd59
228fe8a
9472c23
ad95ef6
0976442
961b106
3c54a24
35d43b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ def test_get_network_connection(self) -> None: | |
|
|
||
| @pytest.mark.skipif(condition=is_ci(), reason='Need to fix flaky test during running on CI') | ||
| def test_set_network_connection(self) -> None: | ||
| nc = self.driver.set_network_connection(ConnectionType.DATA_ONLY) | ||
| assert isinstance(nc, int) | ||
| assert nc == ConnectionType.DATA_ONLY | ||
| try: | ||
| self.driver.set_network_connection(ConnectionType.DATA_ONLY) | ||
| except Exception: | ||
| assert False, "Should not raise any exceptions" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you could also use pytest.fail |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this plugin allow to just set the version to "latest"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it looks like no. I tried the
latestonce but may have failed at that time. After removing the version, I installed v3.8.