[flink] Reject a non-positive scan.split-enumerator.batch-size - #10369
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
PreAssignSplitAssigner#getNext assigns splits while assignment.size() < splitBatchSize, so a non-positive scan.split-enumerator.batch-size makes that loop never run: the enumerator hands out no splits, StaticFileStoreSplitEnumerator reports no-more-splits on the first request, and a bounded read silently returns zero rows instead of failing. Validate the batch size is positive in the assigner constructor -- the single point every source builder funnels through -- so the misconfiguration fails fast at job start. The default is 10, so valid configurations are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PreAssignSplitAssigner#getNextassigns splits whileassignment.size() < splitBatchSize,so a non-positive
scan.split-enumerator.batch-sizemakes that loop never run: theenumerator hands out no splits,
StaticFileStoreSplitEnumeratorreports no-more-splits onthe first request, and a bounded read silently returns zero rows instead of failing.
This validates the batch size is positive in the
PreAssignSplitAssignerconstructor — thesingle point every source builder (
FlinkSourceBuilder,SystemTableSource,CompactorSourceBuilder) funnels through — so the misconfiguration fails fast at job start.The default is
10, so valid configurations are unaffected.Tests
PreAssignSplitAssignerTest#testNonPositiveSplitBatchSizeRejectedasserts0and-1throwa clear
IllegalArgumentException.API and Format
No change.
Documentation
No change.