[python] Preserve full precision in decimal global index keys - #10363
Open
TheR1sing3un wants to merge 1 commit into
Open
TheR1sing3un wants to merge 1 commit into
TheR1sing3un wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DECIMAL global-index keys currently depend on Python's ambient decimal context. A valid DECIMAL(38,2) value such as
123456789012345678901234567890123456.78fails to serialize at the default precision of 28, and decoding its existing unscaled bytes silently rounds away digits. This can break BTree/bitmap equality and range lookups.Use a dedicated context with sufficient precision for scale rounding and reconstruct decoded decimals exactly from their coefficient and scale. Preserve HALF_UP rounding and the existing compact/non-compact byte formats without changing the caller's context.
Tests
global_index_build_test.pyandglobal_index_scalar_search_mode_test.pypass (44 tests).git diff --checkpass.