Sitelet https://github.com/apache/openwhisk-runtime-nodejs/pull/2
Skip to content

Switch to version 3.9.0 of the openwhisk SDK - #2

Merged
csantanapr merged 4 commits into
apache:masterfrom
gbdrt:owversion
Oct 24, 2017
Merged

csantanapr merged 4 commits into
apache:masterfrom
gbdrt:owversion

Conversation

@gbdrt

@gbdrt gbdrt commented Oct 23, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@rabbah

rabbah commented Oct 23, 2017

Copy link
Copy Markdown
Member

@csantanapr are you ok with this change?

@csantanapr csantanapr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don not use .x

@csantanapr

Copy link
Copy Markdown
Member

There is no good thing of using .x more work to figure out what version actually got installed on the image and then update the docs.
It will make it a mess start guessing what version ended in what tag

@csantanapr

Copy link
Copy Markdown
Member

It's not like the library is going to be installed and be updated any time the client lib is release, the npm happens at image creation not at the time action init happens

@gbdrt

gbdrt commented Oct 23, 2017

Copy link
Copy Markdown
Contributor Author

Ok, just changed it back.

@jthomas

jthomas commented Oct 24, 2017

Copy link
Copy Markdown
Member

Is there a way to automate the process of opening a PR each time the openwhisk client lib changes?

@csantanapr

Copy link
Copy Markdown
Member

Yeah we can look into it.
First I would implement a deploy step in Travis, then from the deploy scripts open a PR against this repo.

@gbdrt

gbdrt commented Oct 24, 2017 •

Copy link
Copy Markdown
Contributor Author

I don't know why the build failed.
The last travis output is:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@csantanapr did I missed something?
npm install was successful with v.3.9.0 of the openwhisk SDK, which is the only change I made.

@csantanapr csantanapr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csantanapr
csantanapr merged commit a0bf6fd into apache:master Oct 24, 2017
@gbdrt
gbdrt deleted the owversion branch October 24, 2017 21:56
@csantanapr

Copy link
Copy Markdown
Member

@gbdrt
Don't know what's going on with Travis and docker build.
I restarted the build and it worked.

Now that I created a tag for the image and trying to build it, it also get's stuck already restarted multiple times
https://travis-ci.org/apache/incubator-openwhisk-runtime-nodejs/builds/292315194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants