Run scripts with an unknown extension as Groovy - #217
Merged
Merged
Conversation
Groovy is the second engine for everything BeanShell does here, and the bsh artifact has had no release on Central since 2016. Running a .bsh script now logs a warning; BeanShell becomes an optional dependency in 1.11 and support for it will be removed later (apache/maven#13207).
Up to 1.9 they ran as BeanShell, for compatibility with plugin versions 1.2 and older. BeanShell is deprecated and becomes an optional dependency in 1.11, so the fallback moves to the engine that stays; a warning names the script and the old behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script whose extension matches no registered interpreter ran as BeanShell, a compatibility rule from plugin versions 1.2 and older. It now runs as Groovy, with a warning naming the script and the old behaviour, since BeanShell is deprecated (#216) and becomes an optional dependency in 1.11. Scripts named
.bshand.groovyare unaffected.Stacked on #216; the site page says which version changed the fallback.
Verified:
mvn verify→ 34 tests green, including a new one running averify.scriptcopy of the Groovy test script through the fallback.