Repository navigation
Add validator for component requirements in generated plugin descriptor - #1145
Merged
slawekjaranowski merged 1 commit intoAug 4, 2026
Merged
Conversation
### What changed - Added `ValidateComponentRequirement` to scan generated `PluginDescriptor` mojos for Plexus component requirements (`@Component`-mapped requirements). - Extended integration test verification (`java-basic-annotations/verify.groovy`) to assert the expected warning messages in `build.log`. ### Why - `@Component` usage in mojos is deprecated, but generation currently gives no visible signal when `<requirement>` entries are produced. - A warning at descriptor generation time helps plugin authors migrate toward JSR 330 injection and avoid hidden legacy patterns. Fixes apache#1138
slawekjaranowski
force-pushed
the
fix-1138
branch
from
August 2, 2026 16:40
66ef13b to
0f33b2a
Compare
cstamas
approved these changes
Aug 3, 2026
slawekjaranowski
merged commit Aug 4, 2026
2cdf138
into
apache:maven-plugin-tools-3.x
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ValidateComponentRequirementto scan generatedPluginDescriptormojos for Plexus component requirements (@Component-mapped requirements).java-basic-annotations/verify.groovy) to assert the expected warning messages inbuild.log.Why
@Componentusage in mojos is deprecated, but generation currently gives no visible signal when<requirement>entries are produced.Fixes #1138