Sitelet https://github.com/apache/maven-plugin-tools/pull/1055
Skip to content

JavadocLinkGenerator.createLink(String) must consider module names - #1055

Merged
kwin merged 1 commit into
maven-plugin-tools-3.xfrom
bugfix/javadoc-module-names-for-binary-names-3.x
Dec 23, 2025
Merged

kwin merged 1 commit into
maven-plugin-tools-3.xfrom
bugfix/javadoc-module-names-for-binary-names-3.x

Conversation

@kwin

@kwin kwin commented Dec 23, 2025

Copy link
Copy Markdown
Member

When link towards external javadoc with modules generated include the module name in the URL path

This closes #1038

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

When link towards external javadoc with modules generated include the
module name in the URL path

This closes #1038
@kwin kwin added 3.x backport bug Something isn't working labels Dec 23, 2025
@kwin kwin self-assigned this Dec 23, 2025
@kwin
kwin marked this pull request as ready for review December 23, 2025 15:50
@kwin
kwin merged commit 2afc0f6 into maven-plugin-tools-3.x Dec 23, 2025
30 of 31 checks passed
@kwin
kwin deleted the bugfix/javadoc-module-names-for-binary-names-3.x branch December 23, 2025 15:50
@github-actions github-actions Bot added this to the 3.15.3 milestone Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x backport bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant