Fix #12991: skip shade-plugin upgrade when custom ResourceTransformers are present (backport to 4.0.x) - #13016
Merged
Merged
Conversation
…s are present mvnup upgrades maven-shade-plugin to 3.5.0, but this breaks projects using custom ResourceTransformer implementations that depend on transitive dependencies not available in the newer version (e.g. org.jdom:jdom used by BeansXmlTransformer in myfaces-extcdi). This change detects custom transformer classes in shade-plugin configuration (both top-level and per-execution) and skips the upgrade when found, logging a warning with the list of custom transformers. The check is per-module in multi-module builds, so unaffected modules can still be upgraded.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #12997 to
maven-4.0.x.ResourceTransformerclasses in shade-plugin configuration and skips the upgrade when foundTest plan
🤖 Generated with Claude Code