[MNG-8129] Clarify relativePath validation comment - #12965
Merged
Merged
Conversation
The banned characters are those reserved on Windows (NTFS), which cause InvalidPathException when resolved via java.nio.file.Path. They typically indicate the user put a GAV coordinate instead of a filesystem path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
commented
Aug 31, 2026
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
✅ Looks Good
Trivial comment-only change that correctly replaces an inaccurate claim ("illegal in filesystem paths") with a precise explanation ("reserved on Windows (NTFS)"). No behavioral change. Both validator files (compat and impl) receive identical updates, keeping the parallel implementations consistent.
The added context about InvalidPathException and the GAV coordinate misuse scenario is a helpful clarification for future maintainers.
🔀 Backport Status
- ⏳
master— #12964 (OPEN) - ✅
maven-4.0.x— this PR - ✅
maven-3.10.x— #12966 (MERGED) - ℹ️
maven-3.9.x— not needed (MNG-8129 validation not present on 3.9.x)
🤖 This review was generated by ForgeBot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Comment-only change in both
implandcompatvalidators — no behavior change.🤖 Generated with Claude Code