Remove redundant required attributes from Maven model - #11985
Merged
slawekjaranowski merged 3 commits intoApr 29, 2026
Merged
Conversation
After the fix in the modello plugin required fields are propagated to documentation and xsd. We should remove reduntant one which is not effectively required. Also add additional test for validator.
This was referenced Apr 24, 2026
slawekjaranowski
requested review from
cstamas,
gnodet,
hboutemy and
slachiewicz
April 24, 2026 18:52
we have a default value
cstamas
approved these changes
Apr 29, 2026
This was referenced Jun 23, 2026
gnodet
added a commit
that referenced
this pull request
Jun 25, 2026
…2347) * Forward-port #11985: remove redundant required MDO attrs (#11979) Remove <required>true</required> from 13 metadata/defaulted fields in maven.mdo (forward-port of PR #11985 from maven-3.10.x). Update Model.name description to document artifactId fallback. Add minimal POM validation tests. * Address Copilot review comments - Fix <name> field description in maven.mdo to not claim the model field defaults to artifactId (the fallback is a runtime behavior in MavenProject#getName(), not a model-level default) - Remove unused test POM resources minimal-with-parent.xml and minimal-without-parent.xml from impl/maven-impl (only referenced in compat/maven-model-builder tests which have their own copies) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
Jun 25, 2026
…ion coordinate validation (#11979) (#12346) * Forward-port #11985: remove redundant required MDO attrs + add extension coordinate validation (#11979) - Remove <required>true</required> from 13 metadata/defaulted fields in maven.mdo (forward-port of PR #11985 from maven-3.10.x) - Update Model.name description to document artifactId fallback - Add WARNING-level validation for missing extension groupId/artifactId - Add unit tests for extension coordinate validation and minimal POM validation * Address Copilot review comments (port from #12347) - Fix <name> field description in maven.mdo to not claim the model field defaults to artifactId (the fallback is a runtime behavior in MavenProject#getName(), not a model-level default) Note: unlike the 4.0.x branch, the test POM resources minimal-with-parent.xml and minimal-without-parent.xml are actually referenced by tests in impl/maven-impl on master, so they are kept. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the fix in the modello plugin required fields are propagated to documentation and xsd.
We should remove reduntant one which is not effectively required.
Also add additional test for validator.