report who accepted the connection in ListenAddressBindsOnlyThatAddress - #328
Merged
FreeAndNil merged 2 commits intoSep 28, 2026
Merged
Conversation
FreeAndNil
added a commit
that referenced
this pull request
Sep 25, 2026
FreeAndNil
added a commit
that referenced
this pull request
Sep 27, 2026
build-release.ps1 built the binaries from the working tree but archived the local master ref, so the signed source zip need not match the signed binaries. * Refuse a dirty tree, archive HEAD, and ship a signed .manifest recording the commit and the artifact set. No origin/master check: that needs the network and forbids cutting a release from a tag or a release branch. * Both verifiers check the commit against the zip archive comment and the listed set against the files present. The hash and signature loops only see the files that are there, so an artifact deleted with its .sha512 and .asc passed before. * Everything the release writes gets LF, asserted in the tests. Set-Content writes CRLF on Windows, where a trailing CR breaks sha512sum on macOS and makes every manifest name compare unequal. Includes the .sha512 fix from #328; #328 gets rebased onto this. * sign-log4net-libraries.sh gains set -euo pipefail and shopt -s nullglob. An empty directory iterated the glob patterns and still exited 0. audit da18b6f-f025
FreeAndNil
added a commit
that referenced
this pull request
Sep 27, 2026
FreeAndNil
force-pushed
the
Feature/328-telnet-listen-address-diagnostics
branch
2 times, most recently
from
September 27, 2026 20:18
adfae84 to
44bc08c
Compare
FreeAndNil
added a commit
that referenced
this pull request
Sep 27, 2026
build-release.ps1 built the binaries from the working tree but archived the local master ref, so the signed source zip need not match the signed binaries. * Refuse a dirty tree, archive HEAD, and ship a signed .manifest recording the commit and the artifact set. No origin/master check: that needs the network and forbids cutting a release from a tag or a release branch. * Both verifiers check the commit against the zip archive comment and the listed set against the files present. The hash and signature loops only see the files that are there, so an artifact deleted with its .sha512 and .asc passed before. * Everything the release writes gets LF, asserted in the tests. Set-Content writes CRLF on Windows, where a trailing CR breaks sha512sum on macOS and makes every manifest name compare unequal. Includes the .sha512 fix from #328; #328 gets rebased onto this. * sign-log4net-libraries.sh gains set -euo pipefail and shopt -s nullglob. An empty directory iterated the glob patterns and still exited 0. audit da18b6f-f025
FreeAndNil
added a commit
that referenced
this pull request
Sep 27, 2026
FreeAndNil
added a commit
that referenced
this pull request
Sep 27, 2026
FreeAndNil
force-pushed
the
Feature/328-telnet-listen-address-diagnostics
branch
from
September 27, 2026 20:22
44bc08c to
83147db
Compare
FreeAndNil
added a commit
that referenced
this pull request
Sep 28, 2026
FreeAndNil
force-pushed
the
Feature/328-telnet-listen-address-diagnostics
branch
from
September 28, 2026 06:43
83147db to
e82b676
Compare
FreeAndNil
added a commit
that referenced
this pull request
Sep 28, 2026
- A filtering proxy (ESET on Linux) accepts the connection and closes it, so a successful connect does not mean the appender is reachable - The test now fails only on the greeting or the too-many-connections reply, which only a wrongly bound appender sends
FreeAndNil
marked this pull request as ready for review
September 28, 2026 07:53
fluffynuts
approved these changes
Sep 28, 2026
- A filtering proxy (ESET on Linux) accepts the connection and closes it, so a successful connect does not mean the appender is reachable - The test now fails only on the greeting or the too-many-connections reply, which only a wrongly bound appender sends
FreeAndNil
force-pushed
the
Feature/328-telnet-listen-address-diagnostics
branch
from
September 28, 2026 07:59
c37b2db to
a6afc70
Compare
FreeAndNil
deleted the
Feature/328-telnet-listen-address-diagnostics
branch
September 28, 2026 08:12
This was referenced Oct 1, 2026
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListenAddressBindsOnlyThatAddressassertedThrows.TypeOf<SocketException>(), so a failure saidonly that no exception was thrown. Not enough on a CI agent to tell whether the appender bound
wrongly or something else on the machine listens on that port.
The assertion now carries a message, built only when it fails:
Test-only, one file, no changelog entry.