Sitelet https://github.com/animate-css/animate.css/pull/622
Skip to content

Animate.css Builder Web Version - #622

Closed
Igorxp5 wants to merge 7 commits into
animate-css:gh-pagesfrom
Igorxp5:gh-pages
Closed

Igorxp5 wants to merge 7 commits into
animate-css:gh-pagesfrom
Igorxp5:gh-pages

Conversation

@Igorxp5

@Igorxp5 Igorxp5 commented Aug 5, 2016 •

Copy link
Copy Markdown

Animate.css Builder Web Version

  • The Animate.css Builder updates automatically, just update form > select.

The Root Code ( not test ), is updated with the new animations.

Preview 1

Preview 1

Preview 2

Preview 2

Comment thread index.html
<option value="fadeInUpBig">fadeInUpBig</option>
</optgroup>

<optgroup label="Fading Exits">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@warengonzaga

Copy link
Copy Markdown
Member

Nice Idea! Great Job buddy!

@eltonmesquita

Copy link
Copy Markdown
Collaborator

I do like this a lot, but it'll take a good time to review all the code. I do think that you'll have to adapt it for the new sass version. Will this even be possible?

@warengonzaga

Copy link
Copy Markdown
Member

I can take care over it.

@eltonmesquita

Copy link
Copy Markdown
Collaborator

Great @warengonzaga !

Comment thread index.html Outdated
</form>
<hr />
<p class="meta"><a class="js--triggerSection" href="javascript:void(0);">Animate.css</a> or <a href="https://raw.github.com/daneden/animate.css/master/animate.css" download="animate.css">Download Animate.css</a> or <a href="//github.com/daneden/animate.css">View on GitHub</a></p>
<p><small>Developed by Igorxp5</small></p>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding credits for individuals, let's remove the credit here (and the one to myself on line 151) and provide a link to the project's contributors

@daneden daneden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  • I don't think we need to add custom styles to the checkboxes—system styles will suffice and should shave off some CSS.
  • The added CSS also has some inconsistencies with regard to browser prefixes. I don't think we need anything except the standard CSS properties; please remove all the prefixed properties!
  • I can't remember what the purpose of the test directory is. How certain are we that we need to update that directory? cc @eltonmesquita

Igorxp5 added 2 commits April 28, 2017 16:08
- Removed checbox style.
- Removed all browser prefixes on new css rules.
- Removed chages on the test directory.
- Added a button to check all checkboxs.
@Igorxp5

Igorxp5 commented Apr 28, 2017

Copy link
Copy Markdown
Author

Changed. @daneden

@Igorxp5

Igorxp5 commented Nov 7, 2017

Copy link
Copy Markdown
Author

Added all changes from latest version (Pull Request #720)

@warengonzaga

Copy link
Copy Markdown
Member

It looks like there is a conflict.

@Igorxp5

Igorxp5 commented Nov 29, 2017

Copy link
Copy Markdown
Author

How can I solve this conflict?

@WinWin1St

WinWin1St commented Nov 29, 2017 via email

Copy link
Copy Markdown

@warengonzaga

Copy link
Copy Markdown
Member

I will try to help you to fix your conflict...

@Igorxp5

Igorxp5 commented Dec 1, 2017

Copy link
Copy Markdown
Author

Thank you.

@warengonzaga

Copy link
Copy Markdown
Member

Hello, I'm gonna revise your work it seems too many errors in your code and I can't fix the code that's not my own. I will use your idea to make another one. You can contribute to it. Just fork it. I am having too many issue while updating your fork copy.

@Igorxp5

Igorxp5 commented Dec 2, 2017 •

Copy link
Copy Markdown
Author

Ok. It looks like the problem is only in index.html, but I haven't understood.

@warengonzaga

Copy link
Copy Markdown
Member

Yup in the index.html you copy is outdated don't worry I'm gonna push your builder to the repo. I am creating it now..

@warengonzaga

Copy link
Copy Markdown
Member

Go here: #767 I made a new pull request with your code...

@Igorxp5

Igorxp5 commented Dec 3, 2017

Copy link
Copy Markdown
Author

I understand now, thank you. One question: Would have another way to fix this conflict, other than creating another repo?

@warengonzaga

Copy link
Copy Markdown
Member

You just need to update your current repository and watch for updates in this repository. The trick is always to update your fork with the latest version of the original repository.

@Igorxp5

Igorxp5 commented Dec 4, 2017

Copy link
Copy Markdown
Author

I update the repo to the latest version by some git command? Because I tried copying whole file code and editing it again, changing where was necesary, but it didn't work. (Sorry for the amount of questions, I don't know much about git. After the answer I will close this pull request.)

@warengonzaga

Copy link
Copy Markdown
Member

Let me give you the correct git command so you can update your fork into latest original copy or update:
Go here: https://gist.github.com/WarenGonzaga/66547bb062bbd26de30a99e6baed9a7a

@Igorxp5

Igorxp5 commented Dec 4, 2017

Copy link
Copy Markdown
Author

Very useful, thank you.

@Igorxp5 Igorxp5 closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants