fix(material/form-field): ensure that focused classes are in sync - #31568
Merged
Merged
Conversation
This is something that showed up in some internal tests a while ago. Because we set `mat-focused` through a host binding while `mdc-text-field--focused` is set through direct DOM manipulation, nothing guarantees that they'll be in sync and in some internal tests they aren't. These changes sync both of them up from the same place.
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
July 20, 2025 07:07
adolgachev
approved these changes
Jul 21, 2025
Member
Author
|
The changes were merged into the following branches: main, 20.1.x |
crisbeto
added a commit
that referenced
this pull request
Jul 22, 2025
…1568) This is something that showed up in some internal tests a while ago. Because we set `mat-focused` through a host binding while `mdc-text-field--focused` is set through direct DOM manipulation, nothing guarantees that they'll be in sync and in some internal tests they aren't. These changes sync both of them up from the same place. (cherry picked from commit 8eae162)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that showed up in some internal tests a while ago. Because we set
mat-focusedthrough a host binding whilemdc-text-field--focusedis set through direct DOM manipulation, nothing guarantees that they'll be in sync and in some internal tests they aren't.These changes sync both of them up from the same place.