Sitelet https://github.com/angular/components/pull/28551
Skip to content

fix(cdk/table): error if outlets are assigned too early - #28551

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:28538/table-render-timing
Feb 8, 2024
Merged

fix(cdk/table): error if outlets are assigned too early#28551
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:28538/table-render-timing

Conversation

@crisbeto

@crisbeto crisbeto commented Feb 7, 2024

Copy link
Copy Markdown
Member

Fixes that the table was throwing an error if all outlets are assigned before ngAfterContentInit.

Fixes #28538.

@crisbeto
fix(cdk/table): error if outlets are assigned too early
2dd3212 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes angular#28538.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 7, 2024
@crisbeto crisbeto mentioned this pull request Feb 7, 2024
Closed
1 task done
andrewseguin
andrewseguin reviewed Feb 8, 2024
View reviewed changes
Comment thread src/cdk/table/table.ts
@crisbeto crisbeto self-assigned this Feb 8, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Feb 8, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2024
@crisbeto
crisbeto merged commit add3cd4 into angular:main Feb 8, 2024
crisbeto added a commit that referenced this pull request Feb 8, 2024
@crisbeto
fix(cdk/table): error if outlets are assigned too early (#28551)
f797014 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes #28538.

(cherry picked from commit add3cd4)
crisbeto added a commit that referenced this pull request Feb 8, 2024
@crisbeto
fix(cdk/table): error if outlets are assigned too early (#28551)
2f7aaaa 
Fixes that the table was throwing an error if all outlets are assigned before `ngAfterContentInit`.

Fixes #28538.

(cherry picked from commit add3cd4)
@crisbeto crisbeto mentioned this pull request Feb 22, 2024
Closed
1 task done
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Mar 10, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(CdkTable): render QueryList timing issue in >= 17.1.0

2 participants

@crisbeto @andrewseguin