Repository navigation
Conversation
JeanMeche
reviewed
Sep 6, 2026
Replaces the remaining hand-rolled deferred promise implementations with the native `Promise.withResolvers()` API and removes the now unused helper and import. Follow-up to angular#69739.
MeAkib
force-pushed
the
refactor/drop-manual-deferred-promises-in-tests
branch
from
September 6, 2026 17:40
670544c to
5c683e4
Compare
JeanMeche
requested review from
JeanMeche
and removed request for
kirjs and
rockymeza
September 6, 2026 17:48
JeanMeche
approved these changes
Sep 6, 2026
3 of 14 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69739, applying the same change to the test suites that still hand-roll the deferred promise idiom: declaring an outer
resolve/rejectbinding and capturing the executor arguments into it.Also drops the last two stand-ins for the native API — the
promiseWithResolversimport inresource_spec.tsand the localcreatePromise()helper in the router'sbootstrap.spec.ts.No configuration change is needed here:
packages/tsconfig-build.jsonalready listses2024.promise, and zone.js implementswithResolvers()onZoneAwarePromise, so both the node and browser test targets pick the native API up.