fix(forms): preserve intermediate keystrokes in signal formField - #70391
Open
shoemoney wants to merge 1 commit into
Open
fix(forms): preserve intermediate keystrokes in signal formField#70391shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
Fix verified RED->GREEN. Signal Forms number [formField] overwrites intermediate keystrokes, dropping - and trailing zeros at control_native.ts:124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Signal Forms number [formField] overwriting intermediate keystrokes.
Bug: at control_native.ts:124 the native value write-back calls setNativeControlValue unconditionally when controlValue changes. For number inputs this normalizes the display string via valueAsNumber, dropping incomplete input such as '-' , '1.' and trailing zeros like '1.0' and '1.00' while the user is still typing.
Fix: guard the write-back when the input is focused and the current input.value is intermediate for the pending controlValue. isIntermediate returns true for '-' , '.' , trailing '.' and decimal strings whose numeric value equals controlValue but whose string differs from String(controlValue). In that case keep the raw pending string until blur.
Evidence: RED->GREEN verified with unit simulation for '-', '1.', '1.0', '1.00', '2.10' and formatter blast radius limited to one file. Prettier check passes.